Attention is currently required from: Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67778 )
Change subject: mb/google/skyrim: Implement touchscreen power sequencing
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/67778/comment/ced03567_af0cf4ec
PS3, Line 116: /* EN_PP3300_TCHSCR */
: PAD_GPO(GPIO_131, LOW),
: /* TCHSCR_RESET_L */
: PAD_GPO(GPIO_136, LOW),
Yeah, I think that sounds fine. I don't think on the AMD platforms we ever had a bit.
I think this definitely makes a good reason to have a FW_CONFIG bit to indicate the presence of touch screen.
An alternate is like Raul mentioned, we should assume that touch screen is present. When all the touchscreen modules defined in devicetree could not be probed, we can put these GPIOs as NC?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67778
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449
Gerrit-Change-Number: 67778
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 24 Oct 2022 20:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-MessageType: comment