Attention is currently required from: Mary Ruthven, Joel Kitching, Vadim Bendebury, Christian Walter, Julius Werner, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51164 )
Change subject: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
Looks okay to me. Just some minor nits.
File src/security/tpm/tss/vendor/cr50/cr50.h:
https://review.coreboot.org/c/coreboot/+/51164/comment/a3314e09_e4f5220d
PS1, Line 104: Issue a halt() after triggering EC reset because cr50 leaves 50 ms after receiving
: * the command to reset the EC.
Should the function perform a halt() too instead of expecting the caller to do it?
File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/c/coreboot/+/51164/comment/b355056d_a2c6c970
PS1, Line 155: mode_command
nit: Shouldn't this be named reset_command or just cmd? I think mode_command was used in `tlcl_cr50_get_tpm_mode()` because that command dealt with getting TPM mode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46063678511d27fea5eabbd12fc3af0b1df68143
Gerrit-Change-Number: 51164
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mary Ruthven
mruthven@google.com
Gerrit-Reviewer: Vadim Bendebury
vbendeb@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mary Ruthven
mruthven@google.com
Gerrit-Attention: Joel Kitching
kitching@google.com
Gerrit-Attention: Vadim Bendebury
vbendeb@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 04:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment