Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Ronak Kanabar, Subrata Banik.
Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81630?usp=email )
Change subject: drivers/intel/fsp2_0: Introduce fsp print helper macros
......................................................................
Patch Set 8:
(1 comment)
File src/include/efi/efi_datatype.h:
https://review.coreboot.org/c/coreboot/+/81630/comment/08e6ba2f_8ecd6fd1 :
PS1, Line 65: #if CONFIG(PLATFORM_USES_FSP2_X86_32)
Done
Hi Subrata,
Build bot run is failing with type error after changing the type to UINTN. When using the guards the issue is not seen. Can we fallback to guards ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81630?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6342c4d40c76b702351070e424797c21138a4a9
Gerrit-Change-Number: 81630
Gerrit-PatchSet: 8
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 18 Apr 2024 16:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K
appukuttan.vk@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment