Attention is currently required from: Henry Sun, Stanley Wu, Karthik Ramasubramanian.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51254 )
Change subject: mb/google/dedede/var/boten: update Goodix touch screen sequence
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51254/comment/a48fd22f_a296d5e7
PS1, Line 9: Update Goodix touch screen reset delay time to 180ms.
Where do you get 180ms? Is that from the datasheet or the manufacturer's engineering support?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51254
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98efbe68dab538906802647582eba0e068d9c11f
Gerrit-Change-Number: 51254
Gerrit-PatchSet: 1
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 15:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment