Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83599?usp=email )
Change subject: gma: Re-structure TC port types ......................................................................
Patch Set 1:
(1 comment)
File common/hw-gfx-gma-config_helpers.adb:
https://review.coreboot.org/c/libgfxinit/+/83599/comment/b2ae62bf_22312eac?u... : PS1, Line 68: : when DP_TC1 | HDMI_TC1 | USBC1 => DDI_TC3, : when DP_TC2 | HDMI_TC2 | USBC2 => DDI_TC4, : when DP_TC3 | HDMI_TC3 | USBC3 => DDI_TC5, : when DP_TC4 | HDMI_TC4 | USBC4 => DDI_TC6,
Might be a brainfart anyway. They use ports F..I in the ADL VBT instead […]
ADL-P (XeLPD) doesn't even have TC5 .. TC6 so it definitely feels wrong. Also, I remember the ADL patches from Chrome folks only map registers for TC1 .. TC4 on ADL.