Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46783 )
Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Serialize GWAK method ......................................................................
sb/intel/lynxpoint/acpi/gpio.asl: Serialize GWAK method
Commit 576b7c7 (broadwell: gpio.asl: Make GWAK method serialized) made GWAK serialized for Broadwell. This commit follows suit on Lynx Point.
The reason to serialize this method is because it creates named objects which depend on input parameters, and thus cannot be created elsewhere.
Change-Id: I892700df3bba079e3280008f619017e3954d5a06 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/46783/1
diff --git a/src/southbridge/intel/lynxpoint/acpi/gpio.asl b/src/southbridge/intel/lynxpoint/acpi/gpio.asl index 1a50968..358bdec 100644 --- a/src/southbridge/intel/lynxpoint/acpi/gpio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/gpio.asl @@ -47,7 +47,7 @@
// GWAK: Setup GPIO as ACPI GPE for Wake // Arg0: GPIO Number - Method (GWAK, 1, NotSerialized) + Method (GWAK, 1, Serialized) { // Local0 = GPIO Base Address Store (GPBS & ~1, Local0)
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46783 )
Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Serialize GWAK method ......................................................................
Patch Set 8: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46783 )
Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Serialize GWAK method ......................................................................
sb/intel/lynxpoint/acpi/gpio.asl: Serialize GWAK method
Commit 576b7c7 (broadwell: gpio.asl: Make GWAK method serialized) made GWAK serialized for Broadwell. This commit follows suit on Lynx Point.
The reason to serialize this method is because it creates named objects which depend on input parameters, and thus cannot be created elsewhere.
Change-Id: I892700df3bba079e3280008f619017e3954d5a06 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46783 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/lynxpoint/acpi/gpio.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/acpi/gpio.asl b/src/southbridge/intel/lynxpoint/acpi/gpio.asl index 1a50968..358bdec 100644 --- a/src/southbridge/intel/lynxpoint/acpi/gpio.asl +++ b/src/southbridge/intel/lynxpoint/acpi/gpio.asl @@ -47,7 +47,7 @@
// GWAK: Setup GPIO as ACPI GPE for Wake // Arg0: GPIO Number - Method (GWAK, 1, NotSerialized) + Method (GWAK, 1, Serialized) { // Local0 = GPIO Base Address Store (GPBS & ~1, Local0)
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)