Change in coreboot[master]: Makefile: set TZ LANG LC_ALL

[Alexander Couzens (Code Review)]

Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Makefile: set TZ LANG LC_ALL

To be reproducible, TZ LANG LC_ALL should be set early
in the build process to be always used.

Change-Id: Iad802968347c8d41f974af930e0d0ad5b66719cb
---
M Makefile
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/35391/1

diff --git a/Makefile b/Makefile
index f0a22a5..deb80a4 100644
--- a/Makefile
+++ b/Makefile
@@ -39,6 +39,11 @@
 objk := $(objutil)/kconfig
 absobj := $(abspath $(obj))

+LC_ALL:=C
+LANG:=C
+TZ:=UTC0
+export LC_ALL LANG TZ
+
 COREBOOT_EXPORTS := COREBOOT_EXPORTS
 COREBOOT_EXPORTS += top src srck obj objutil objk

[Alexander Couzens (Code Review)]

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Patch Set 4:

This change is ready for review.

[Stefan Reinauer (Code Review)]

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Patch Set 4: Code-Review+1

I thought were were already reproducible? For which circumstances is this needed? How can one reproduce irreproducibility without this patch?

[Alexander Couzens (Code Review)]

Alexander Couzens has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Patch Set 4:
> Patch Set 4: Code-Review+1
>
> I thought were were already reproducible? For which circumstances is this needed? How can one reproduce irreproducibility without this patch?

Yes, coreboot is in general reproducible. We're also setting these environemtns in the most shell scripts again (e.g. genbuild_h.sh).
However all $(shell ..) get also influenced by these variables.
Also 3rd party builds which don't do unexport COREBOOT_EXPORTS get influenced as well.

It's more a precaution to have it clear for the whole build instead of only the selective parts of the build.

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35391 )

Change subject: Makefile: set TZ LANG LC_ALL
......................................................................

Makefile: set TZ LANG LC_ALL

To be reproducible, TZ LANG LC_ALL should be set early
in the build process to be always used.

Change-Id: Iad802968347c8d41f974af930e0d0ad5b66719cb
Signed-off-by: Alexander Couzens 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35391
Tested-by: build bot (Jenkins) 
Reviewed-by: Stefan Reinauer 
Reviewed-by: Philipp Deppenwiese 
---
M Makefile
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Stefan Reinauer: Looks good to me, but someone else must approve
  Philipp Deppenwiese: Looks good to me, approved

diff --git a/Makefile b/Makefile
index f0a22a5..52cba69 100644
--- a/Makefile
+++ b/Makefile
@@ -42,6 +42,12 @@
 COREBOOT_EXPORTS := COREBOOT_EXPORTS
 COREBOOT_EXPORTS += top src srck obj objutil objk

+# reproducible builds
+LANG:=C
+LC_ALL:=C
+TZ:=UTC0
+COREBOOT_EXPORTS += LANG LC_ALL TZ
+
 DOTCONFIG ?= $(top)/.config
 KCONFIG_CONFIG = $(DOTCONFIG)
 KCONFIG_AUTOADS := $(obj)/cb-config.ads