Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69427 )
Change subject: src/drivers/wifi: Fix DSM parsing issue ......................................................................
src/drivers/wifi: Fix DSM parsing issue
CB:61020 restructured the DSM implementation which resulted in a regression and DSM values gets filled with junk values. This CL fixes this issue and passes the right pointer to the dsm ids structure.
BUG=b:256938177 TEST=Build,boot Nivviks and check if the DSM values are parsed correctly in the SSDT dump.
Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com Change-Id: I88782b0b7dde1fca0230472a38628e82dfd9c26c --- M src/drivers/wifi/generic/acpi.c 1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/69427/1
diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index ee122ea..869b92a 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -488,7 +488,7 @@
/* copy the dsm data to be later used for creating _DSM function */ if (sar_limits.dsm != NULL) - memcpy(dsm, &sar_limits.dsm, sizeof(struct dsm_profile)); + memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile));
free(sar_limits.sar); } @@ -571,7 +571,7 @@ dsm_ids[dsm_count].uuid = ACPI_DSM_OEM_WIFI_UUID; dsm_ids[dsm_count].callbacks = &wifi_dsm_callbacks[0]; dsm_ids[dsm_count].count = ARRAY_SIZE(wifi_dsm_callbacks); - dsm_ids[dsm_count].arg = NULL; + dsm_ids[dsm_count].arg = &dsm; dsm_count++; } }