[L] Change in coreboot[master]: acpi/acpi.c: Move ACPI header creation to a function - coreboot-gerrit

28 Jun 2023


      Attention is currently required from: Arthur Heymans, Lance Zhao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76143?usp=email )
Change subject: acpi/acpi.c: Move ACPI header creation to a function
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76143/comment/1b2cb03e_85372dec :
PS1, Line 9: This reduces boilerplate.
           : One functional difference is that SSDT no longer has oem_revision set to
           : 42.
nit, no need for line break after first sentence
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/76143?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2e54d61970294e028a61ba86c07c5482784e307
Gerrit-Change-Number: 76143
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 28 Jun 2023 13:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment