[XL] Change in coreboot[main]: soc/meidatek/mt8196: Add SPM loader

[Yidi Lin (Code Review)]

Attention is currently required from: Ccong Chen, Hung-Te Lin, Wenzhen Yu, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )

Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................

Patch Set 1:

(16 comments)

File src/soc/mediatek/common/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/f7fdab66_d5988397?usp... :
PS1, Line 59: #ifndef CONFIG_MEDIATEK_SPM_V2
if (!CONFIG(MEDIATEK_SPM_V2))

Please explain in the commit message why the following setting is not needed on mt8196.

https://review.coreboot.org/c/coreboot/+/85599/comment/21e80cd5_5adbfc4b?usp... :
PS1, Line 101: CONFIG_MEDIATEK_SPM_V2
if (!CONFIG(MEDIATEK_SPM_V2))

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/f12635b8_c4a9abda?usp... :
PS1, Line 508: u32 spm_power_on_val[4];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/e12a4422_8290a73c?usp... :
PS1, Line 535: u32 md32pcm_scu_ctrl[4];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/ed858277_2671a36f?usp... :
PS1, Line 562: u32 sw2spm_mailbox[4];
             : 	u32 spm2sw_mailbox[4];
             : 
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/af5e328c_0472afd8?usp... :
PS1, Line 575: 	u32 pcm_apwdt_latch[20];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/24efaec5_bbe93016?usp... :
PS1, Line 591: u32 spm_dpsw_con;
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/afab2871_6fd84000?usp... :
PS1, Line 645: 	struct {
             : 		u32 latch_l;
             : 		u32 latch_h;
             : 	} sys_timer_latch[16];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/2642f38b_c846d224?usp... :
PS1, Line 654: u32 pcm_apwdt_latch_20[19];
             : 	u8  reserved18[4];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/01f3327e_2f4fa341?usp... :
PS1, Line 660: u32 spm_sw_rsv[9];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/472d7112_c9f34364?usp... :
PS1, Line 684: u32 spm_sema_m[8];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/f363c798_c5a5d043?usp... :
PS1, Line 687: u32 spm2pmcu_mailbox[4];
             : 	u32 pmcu2spm_mailbox[4];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/1dff1b27_0b7b24cc?usp... :
PS1, Line 704: u32 spm_src_mask[12];
             : 	u32 spm_req_sta[12];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/d0c76ffc_e2fc2a8b?usp... :
PS1, Line 710: u32 spm_resource_ack_con[2];
             : 	u32 spm_resource_ack_mask[9];
Keep it unmodified.

https://review.coreboot.org/c/coreboot/+/85599/comment/83f8fe6f_f2710bfc?usp... :
PS1, Line 717: [1]
remove `[1]`

https://review.coreboot.org/c/coreboot/+/85599/comment/209dc9a9_24213def?usp... :
PS1, Line 968: 	u32 spm_src_mask_17;
             : 	u32 spm_src_mask_18;
             : 	u32 spm_resource_ack_mask_13;
             : 	u32 spm_resource_ack_mask_14;
The offsets are varied previous version. Please make sure the offsets are correct.