Attention is currently required from: Mac Chiang, Pranava Y N, Varun Upadhyay, Weimin Wu.
Subrata Banik has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/85571?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/soundwire: Support Realtek ALC712 codec
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85571/comment/a4b649cf_a6cd0a5d?usp... :
PS2, Line 13: static struct soundwire_multilane alc711_multilane = {
: };
do you wish to keep the default value for case when chip config hasn't been provided `config->multilane.lane_mapping`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85571?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib79896a9fe23f2f66d6ee3a24f5a62bfa0f7a649
Gerrit-Change-Number: 85571
Gerrit-PatchSet: 2
Gerrit-Owner: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Mac Chiang
mac.chiang@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Mac Chiang
mac.chiang@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 13 Dec 2024 05:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No