Attention is currently required from: Cliff Huang, Jincheng Li, Lance Zhao, Shuo Liu, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84324?usp=email )
Change subject: acpi: Create MADT lapic entries according to current lapic mode
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I'm not sure that the current lapic mode is relevant for passing info to OS.
Maybe always using x2apic if that is available is more reasonable than the current mix.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84324/comment/6e4dd771_b3f1147b?usp... :
PS1, Line 9: Introduce a new function is_x2apic_mode() to tell current lapic
: mode and create the lapic entries accordingly.
Explain why?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84324?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I197ceeabd8a789abcd72459493a63ea267af4a16
Gerrit-Change-Number: 84324
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Thu, 12 Sep 2024 10:53:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No