Attention is currently required from: Jan Philipp Groß, Máté Kukri.
Felix Singer has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82760?usp=email )
Change subject: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell)
......................................................................
Patch Set 15:
(2 comments)
File src/mainboard/asrock/z97e-itx_ac/Kconfig:
https://review.coreboot.org/c/coreboot/+/82760/comment/fe4ac5f6_a2d7879f?usp... :
PS15, Line 1: ## SPDX-License-Identifier: GPL-2.0-or-later
Add blank line here.
Let's do that at some point later. Done.
File src/mainboard/asrock/z97e-itx_ac/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/82760/comment/d7420bfd_951557bf?usp... :
PS15, Line 18: /* global NVS and variables. */
Seems superfluous. Please remove.
Let's do that at some point later. Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82760?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b940e9281814e8360900221714c0dfa3ae39540
Gerrit-Change-Number: 82760
Gerrit-PatchSet: 15
Gerrit-Owner: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Jan Philipp Groß
jeangrande@mailbox.org
Gerrit-Comment-Date: Wed, 03 Jul 2024 17:57:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de