Attention is currently required from: Jason Glenesk, Paul Menzel, Felix Held.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69705 )
Change subject: mb/amd/birman: Update DXIO descriptors per schematic ......................................................................
Patch Set 18:
(2 comments)
File src/mainboard/amd/birman/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/69705/comment/6d96d6c5_9e618c4f PS16, Line 113: .start_logical_lane = 15, \ : .end_logical_lane = CONFIG(WLAN01) ? 14 : 15, \
can the start lane be greater than the end lane? might be a good idea to try if the dxio logic will […]
Tested and checked the logs in FSP - it detects the reversed order case and handles it properly
File src/mainboard/amd/birman/port_descriptors_phoenix.c:
https://review.coreboot.org/c/coreboot/+/69705/comment/045406ef_6fdee468 PS17, Line 65: CLK_REQ4
CLK_REQ1?
Done
-
Fred Reitberger (Code Review)