Attention is currently required from: Nico Huber. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61685 )
Change subject: mb/google/reef: Add VBTs for all variants ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/reef/variants/coral/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61685/comment/47c3e5b9_ccc328a0 PS1, Line 14: $(call add_vbt_to_cbfs, vbt-santa.bin, santa-data.vbt)
Should these be guarded with INTEL_GMA_ADD_VBT like the generic data.vbt is? […]
is that necessary since the board selects INTEL_GMA_ADD_VBT? it doesn't seem to be guarded in any boards which add extra VBTs, so the empty macro might be the way to go