Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74344 )
Change subject: soc/amd/common: Identify FSP HOB type GUIDs ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: haven't looked at the actual guids yet; only at the general code
File src/soc/amd/common/fsp/hob_display.c:
PS1: i personally would prefer to use the coreboot type guid_t and the macro GUID_INIT instead of the EFI type EFI_GUID. that's what's used in the soc/amd subtree; soc/intel and the FSP driver however use the non-coreboot-native EFI types. either way works and the binary representation ends up being the same, so i don't have a very strong opinion on this
https://review.coreboot.org/c/coreboot/+/74344/comment/01e3fa9a_c4505bba PS1, Line 5: #include <lib.h> i don't see what this is needed for. you'll need to include types.h or the more specific header that provides the size_t definition
-
Felix Held (Code Review)