Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74404 )
(
5 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: device: Move D3COLD_SUPPORT symbol ......................................................................
device: Move D3COLD_SUPPORT symbol
Move D3COLD_SUPPORT to device, so it can be used by multiple SOCs.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: Ie92736458ab95374c51346107665dc0fd1e653a4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74404 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michael Niewöhner foss@mniewoehner.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/Kconfig M src/soc/intel/alderlake/Kconfig 2 files changed, 31 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index ef73c40..cdd843c 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -998,6 +998,20 @@ help Provides xHCI utility functions.
+config D3COLD_SUPPORT + bool + default y + help + Enable this option if all devices on your system support the + D3Cold power management state. The D3Cold state is a low-power + state where the device has been powered down and is no longer + able to maintain its context. This state can help reduce + overall system power consumption, which can be beneficial for + energy savings and thermal management. + + Please note that enabling D3Cold support may break system + suspend-to-RAM (S3) functionality. + source "src/device/dram/Kconfig"
endmenu diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 9c80054..cce2052 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -332,20 +332,6 @@ int default 8
-config D3COLD_SUPPORT - bool - default y - help - Enable this option if all devices on your system support the - D3Cold power management state. The D3Cold state is a low-power - state where the device has been powered down and is no longer - able to maintain its context. This state can help reduce - overall system power consumption, which can be beneficial for - energy savings and thermal management. - - Please note that enabling D3Cold support may break system - suspend-to-RAM (S3) functionality. - config ENABLE_SATA_TEST_MODE bool "Enable test mode for SATA margining" default n