Attention is currently required from: Andrey Petrov, Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Paul Menzel, Tarun.
Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83769?usp=email )
Change subject: soc/intel/mtl: enable FSP uGOP config in MTL for eSOL
......................................................................
Patch Set 18:
(1 comment)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83769/comment/de71406d_3215f6a0?usp... :
PS18, Line 514: FSP_UGOP_EARLY_SIGN_OF_LIFE
That wouldn't be correct, though: if using libgfxinit for eSOL, the FSP-M UPDs don't need to be populated.
eSOL is a feature that can be implemented using two different technologies:
(A) FSP uGOP
(B) libgfxinit
For (A), we need to override UPD, which is where this file comes in.
For MTL onwards on the Intel platform, libgfxinit support is not POR. So, the only option we have now is supporting eSOL using uGOP. Therefore, whether we are using FSP_UGOP_EARLY_SIGN_OF_LIFE or CHROMEOS_ENABLE_ESOL, both are eventually the same starting with the MTL platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83769?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4589f52080229b1c83915b51272a042b7ac32cd
Gerrit-Change-Number: 83769
Gerrit-PatchSet: 18
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 08 Aug 2024 06:42:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com