[M] Change in coreboot[main]: sio/nuvoton: Implement a common ramstage ACPI LDN helper - coreboot-gerrit

3 Jun 2024


      Attention is currently required from: Keith Hui, Paul Menzel.
Nico Huber has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82632?usp=email )
Change subject: sio/nuvoton: Implement a common ramstage ACPI LDN helper
......................................................................
Patch Set 6:
(1 comment)
File src/superio/nuvoton/common/common.c:
https://review.coreboot.org/c/coreboot/+/82632/comment/fa8df7a6_644e5f34?usp... :
PS6, Line 79: 	 * Clear case open pin 0 status.
...
Just put it in a known state. […]
But how if we clear it on boot? Assuming somebody opened the case, tampered, closed
again, user boots, we clear it, how'd the user know?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82632?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaddcaa2d77c5b06ddfbb6dbaac00df5e72dd4bd
Gerrit-Change-Number: 82632
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui buurin@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Keith Hui buurin@gmail.com
Gerrit-Comment-Date: Mon, 03 Jun 2024 18:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Keith Hui buurin@gmail.com