Change in coreboot[master]: libpayload: Provide includes for payloads

[Patrick Georgi (Code Review)]

Attention is currently required from: Jakub Czapiga.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59916 )

Change subject: libpayload: Provide includes for payloads
......................................................................

Patch Set 2:

(3 comments)

File payloads/libpayload/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/59916/comment/df063b8a_aff30f02 
PS1, Line 74: early-headers-install:
> Is there any way to "cache" *.h files easily? I do not want to create dep-files by hand.

I suppose this question will become moot when we don't have that early header install step anymore?

File payloads/libpayload/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/59916/comment/102d7a76_c37557d6 
PS2, Line 75: 	printf "    INSTALL    $(obj)/libpayload/include\n"
            : 	install -m 755 -d "$(obj)/libpayload/include"
            : 	for file in `find include -name *.h -type f`; do \
            : 		install -m 755 -d "$(obj)/libpayload/`dirname $$file`"; \
            : 		install -m 644 "$$file" "$(obj)/libpayload/$$file"; \
            : 	done
            : 	for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \
            : 		dest_file=$$(realpath --relative-to=$(coreboottop)/src/commonlib/bsd/ $$file); \
            : 		install -m 755 -d "$(obj)/libpayload/`dirname $$dest_file`"; \
            : 		install -m 644 "$$file" "$(obj)/libpayload/$$dest_file"; \
            : 	done
> I am not sure, if we really need this. […]

Seeing what this requires it might indeed be easier to just ensure that "make install" copies commonlib into place and ignore users that pick apart the build/ directory.

https://review.coreboot.org/c/coreboot/+/59916/comment/5f933284_eb85862d 
PS2, Line 132: for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \
> Do we want to provide (PD)curses includes? […]

The scope of this change is to copy commonlib in place, I'd ignore any issues about pdcurses here.

Changing the build directory structure _might_ help, but it's also more involved than just copying the right files in the install step, so while I thought that might be a good idea, it apparently is more complicated than it's worth.