Change in ...coreboot[master]: lib/edid.c: Log an error if unable to find edid or header
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32084
Change subject: lib/edid.c: Log an error if unable to find edid or header ......................................................................
lib/edid.c: Log an error if unable to find edid or header
Failure to find an EDID or header is more serious than the spew log level and should be an error.
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I660218f8b5f5e7f0b01daef0739db79418941515 --- M src/lib/edid.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/32084/1
diff --git a/src/lib/edid.c b/src/lib/edid.c index 5925759..d56099b 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -1141,14 +1141,14 @@ memset(out, 0, sizeof(*out));
if (!edid) { - printk(BIOS_SPEW, "No EDID found\n"); + printk(BIOS_ERR, "No EDID found\n"); return EDID_ABSENT; }
dump_breakdown(edid);
if (memcmp(edid, "\x00\xFF\xFF\xFF\xFF\xFF\xFF\x00", 8)) { - printk(BIOS_SPEW, "No header found\n"); + printk(BIOS_ERR, "No header found\n"); return EDID_ABSENT; }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32084
to look at the new patch set (#2).
Change subject: lib/edid.c: Log an error if unable to find edid or header ......................................................................
lib/edid.c: Log an error if unable to find edid or header
Failure to find an edid or header is more serious than the spew log level and should be an error.
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I660218f8b5f5e7f0b01daef0739db79418941515 --- M src/lib/edid.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/32084/2
Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32084 )
Change subject: lib/edid.c: Log an error if unable to find edid or header ......................................................................
Patch Set 2:
This is a follow-up to my previous null checking commit.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32084 )
Change subject: lib/edid.c: Log an error if unable to find edid or header ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32084 )
Change subject: lib/edid.c: Log an error if unable to find edid or header ......................................................................
lib/edid.c: Log an error if unable to find edid or header
Failure to find an edid or header is more serious than the spew log level and should be an error.
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I660218f8b5f5e7f0b01daef0739db79418941515 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32084 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/edid.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/lib/edid.c b/src/lib/edid.c index 5925759..d56099b 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -1141,14 +1141,14 @@ memset(out, 0, sizeof(*out));
if (!edid) { - printk(BIOS_SPEW, "No EDID found\n"); + printk(BIOS_ERR, "No EDID found\n"); return EDID_ABSENT; }
dump_breakdown(edid);
if (memcmp(edid, "\x00\xFF\xFF\xFF\xFF\xFF\xFF\x00", 8)) { - printk(BIOS_SPEW, "No header found\n"); + printk(BIOS_ERR, "No header found\n"); return EDID_ABSENT; }
-
Jacob Garber (Code Review) -
Patrick Georgi (Code Review)