Change in coreboot[master]: mb/opencellular/elgon: Fix typo

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

12 Jan 2020 12 Jan '20

9:31 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

mb/opencellular/elgon: Fix typo

Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/opencellular/elgon/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/38371/1

diff --git a/src/mainboard/opencellular/elgon/bootblock.c b/src/mainboard/opencellular/elgon/bootblock.c index c7f2639..5bba5fd 100644 --- a/src/mainboard/opencellular/elgon/bootblock.c +++ b/src/mainboard/opencellular/elgon/bootblock.c @@ -39,7 +39,7 @@

static void configure_spi_flash(void) { - /* The maximum SPI frequency for error free transmission is at 30 Mhz */ + /* The maximum SPI frequency for error free transmission is at 30 MHz */ spi_init_custom(0, // bus 28000000, // speed Hz 0, // idle low disabled

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Angel Pons (Code Review)

12 Jan 12 Jan

10:58 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/38371/1/src/mainboard/opencellular/... File src/mainboard/opencellular/elgon/bootblock.c:

https://review.coreboot.org/c/coreboot/+/38371/1/src/mainboard/opencellular/... PS1, Line 42: error free error-free

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 12 Jan 2020 09:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38371/1/src/mainboard/opencellular/... File src/mainboard/opencellular/elgon/bootblock.c:

https://review.coreboot.org/c/coreboot/+/38371/1/src/mainboard/opencellular/... PS1, Line 42: error free

...

error-free

Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 12 Jan 2020 10:00:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:01 a.m.

Hello Angel Pons, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38371

to look at the new patch set (#2).

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

mb/opencellular/elgon: Fix typo

Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/opencellular/elgon/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/38371/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

13 Jan 13 Jan

2:08 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 13 Jan 2020 13:08:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

18 Jan 18 Jan

11:56 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 18 Jan 2020 10:56:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

11:56 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38371 )

Change subject: mb/opencellular/elgon: Fix typo ......................................................................

mb/opencellular/elgon: Fix typo

Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38371 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/mainboard/opencellular/elgon/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/mainboard/opencellular/elgon/bootblock.c b/src/mainboard/opencellular/elgon/bootblock.c index c7f2639..baf6391 100644 --- a/src/mainboard/opencellular/elgon/bootblock.c +++ b/src/mainboard/opencellular/elgon/bootblock.c @@ -39,7 +39,7 @@

static void configure_spi_flash(void) { - /* The maximum SPI frequency for error free transmission is at 30 Mhz */ + /* The maximum SPI frequency for error-free transmission is at 30 MHz */ spi_init_custom(0, // bus 28000000, // speed Hz 0, // idle low disabled

-- To view, visit https://review.coreboot.org/c/coreboot/+/38371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6724637c7333ae6be7ada3e8ebe878b2a1061dd1 Gerrit-Change-Number: 38371 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1763

days inactive

1769

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)