Change in ...coreboot[master]: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Ren Kuo (Code Review)

7 Mar 2019 7 Mar '19

9:28 p.m.

Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31803

Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku ......................................................................

mb/google/poppy/variant/nami: change the vbt bin loading for bard sku

remove the bard vbt bin in coreboot,and add it in cbfs(CL:990403) to fix the bugs

BUG=b:127552559 b:127611290 TEST= build the coreboot and firmware include CL:990403 to verify

Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/variants/nami/Makefile.inc D src/mainboard/google/poppy/variants/nami/bard-data.vbt 2 files changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31803/1

diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc index dc80357..7f86bb7 100644 --- a/src/mainboard/google/poppy/variants/nami/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc @@ -41,5 +41,3 @@ cbfs-files-y += oem.bin oem.bin-file := $(call strip_quotes,$(CONFIG_OEM_BIN_FILE)) oem.bin-type := raw - -$(call add_vbt_to_cbfs, vbt-bard.bin, bard-data.vbt) diff --git a/src/mainboard/google/poppy/variants/nami/bard-data.vbt b/src/mainboard/google/poppy/variants/nami/bard-data.vbt deleted file mode 100644 index cdaca6a..0000000 --- a/src/mainboard/google/poppy/variants/nami/bard-data.vbt +++ /dev/null Binary files differ

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Ren Kuo (Code Review)

7 Mar 7 Mar

9:29 p.m.

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31803 )

Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 1 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Comment-Date: Thu, 07 Mar 2019 10:29:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ren Kuo (Code Review)

9:52 p.m.

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31803

to look at the new patch set (#2).

Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku ......................................................................

mb/google/poppy/variant/nami: change the vbt bin loading for bard sku

remove the bard vbt bin in coreboot,and add it in cbfs(CL:*990403) to fix the bugs

BUG=b:127552559 b:127611290 TEST= build the coreboot and firmware include CL:*990403 to verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31803/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Vincent Wang vwang@google.com Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

8 Mar 8 Mar

12:19 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31803 )

Change subject: mb/google/poppy/variant/nami: change the vbt bin loading for bard sku ......................................................................

Patch Set 2:

(6 comments)

You should not score your on change-set.

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: coreboot,and Please add a space after the comma (,).

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: cbfs(CL:*990403) Please add a space before the opening bracket (.

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: vbt VBT

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: remove Remove

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@10 PS2, Line 10: to fix the bugs Please elaborate, what bug is fixed. Not all reviewers have access to the bug report.

https://review.coreboot.org/#/c/31803/2//COMMIT_MSG@9 PS2, Line 9: remove the bard vbt bin in coreboot,and add it in cbfs(CL:*990403) : to fix the bugs Please add a dot/period at the end.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 2 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Vincent Wang vwang@google.com Gerrit-Comment-Date: Thu, 07 Mar 2019 13:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ren Kuo (Code Review)

12:10 p.m.

New subject: Change in ...coreboot[master]: mb/google/poppy/variant/nami: change the VBT loading for bard sku

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31803

to look at the new patch set (#3).

Change subject: mb/google/poppy/variant/nami: change the VBT loading for bard sku ......................................................................

mb/google/poppy/variant/nami: change the VBT loading for bard sku

Remove the bard VBT in coreboot, and add it in cbfs (CL:*990403) to fix the two bugs as following.

Bug 1: (b:127552559) Bard: System unable to show up the recovery mode screen and DEV mode screen

Bug 2: (b:127611290) Suspend stress FAIL by ERROR: Failed to clear screen

BUG=b:127552559 b:127611290 TEST= build the coreboot and firmware include CL:*990403 to verify

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31803/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Vincent Wang vwang@google.com Gerrit-MessageType: newpatchset

Ren Kuo (Code Review)

12:11 p.m.

New subject: Change in ...coreboot[master]: mb/google/poppy/variant/nami: change the VBT loading for bard sku

Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31803 )

Change subject: mb/google/poppy/variant/nami: change the VBT loading for bard sku ......................................................................

Patch Set 3:

...

Patch Set 2:

(6 comments)

You should not score your on change-set.

Modified the commit message.Please help to review it again.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Vincent Wang vwang@google.com Gerrit-Comment-Date: Fri, 08 Mar 2019 01:11:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ren Kuo (Code Review)

11 Mar 11 Mar

12:47 p.m.

New subject: Change in ...coreboot[master]: mb/google/poppy/variant/nami: change the VBT loading for bard sku

Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31803 )

Change subject: mb/google/poppy/variant/nami: change the VBT loading for bard sku ......................................................................

Abandoned

Furquan Shaikh furquan@google.com #8 Mar 9, 2019 02:21AM Ren, the issue is that this CL was never cherry-picked to nami branch. Can you please try only this CL cherry-picked to nami branch to see if it fixes the problem for you: https://chromium-review.googlesource.com/1392644

-- To view, visit https://review.coreboot.org/c/coreboot/+/31803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1202de5757a3e0703ebbe201e57be3ee7a47fa0d Gerrit-Change-Number: 31803 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Ren Kuo ren.kuo@quanta.corp-partner.google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Vincent Wang vwang@google.com Gerrit-MessageType: abandon

2037

days inactive

2041

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Paul Menzel (Code Review)
Ren Kuo (Code Review)