Attention is currently required from: Nico Huber, Tim Wawrzynczak, Nick Vaccaro. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 31:
(3 comments)
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/6f6ae59c_8eab3850 PS31, Line 251: info->type_c_info = get_cbmem_addr(ptr); (void *)
File src/commonlib/include/commonlib/cbmem_id.h:
PS31:
should this part go in CB:57345 ?
This is actually required for coreboot_table.c in this CL.
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/1e15ce36_026e16ea PS27, Line 431: enum type_c_orientation {
I would also have to bring in a change to conn.c as well. […]
I like the idea of adding the enum in a follow-up. Rather than squashing it into CB:57345 probably you can add a CL in between which introduces the enum in coreboot_tables.h and drops it from chip.h. And then CB:57345 which adds type-c port info to cbmem for intel platforms.
-
Furquan Shaikh (Code Review)