Change in ...coreboot[master]: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31193

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place

Change-Id: I51aa300358013cb0e76704feb2115d2a7e260f8a
Signed-off-by: Elyes HAOUAS 
---
M src/include/cpu/x86/msr.h
M src/soc/intel/denverton_ns/include/soc/msr.h
2 files changed, 2 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/31193/1

diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 31c921d..733205a 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -37,6 +37,8 @@
 #define IA32_PERF_CTL			0x199
 #define IA32_THERM_INTERRUPT		0x19b
 #define IA32_MISC_ENABLE		0x1a0
+#define  FAST_STRINGS_ENABLE_BIT	(1 << 0)
+#define  SPEED_STEP_ENABLE_BIT		(1 << 16)
 #define IA32_ENERGY_PERF_BIAS		0x1b0
 #define  ENERGY_POLICY_PERFORMANCE	0
 #define  ENERGY_POLICY_NORMAL		6
diff --git a/src/soc/intel/denverton_ns/include/soc/msr.h b/src/soc/intel/denverton_ns/include/soc/msr.h
index 1b27eef..0d469c4 100644
--- a/src/soc/intel/denverton_ns/include/soc/msr.h
+++ b/src/soc/intel/denverton_ns/include/soc/msr.h
@@ -96,10 +96,6 @@
 #define SMRR_SUPPORTED (1 << 11)
 #define PRMRR_SUPPORTED (1 << 12)

-/* IA32_MISC_ENABLE bits */
-#define FAST_STRINGS_ENABLE_BIT (1 << 0)
-#define SPEED_STEP_ENABLE_BIT (1 << 16)
-
 /* Read BCLK from MSR */
 unsigned int bus_freq_khz(void);

[David Guckian (Code Review)]

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Patch Set 1: Code-Review+1

[Vanessa Eusebio (Code Review)]

Vanessa Eusebio has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Patch Set 1: Code-Review+1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Abandoned

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Restored

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Uploaded patch set 2: Patch Set 1 was rebased.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Uploaded patch set 3: Patch Set 2 was rebased.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31193 )

Change subject: cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place
......................................................................

cpu/x86/msr: Move IA32_MISC_ENABLE bits to common place

Change-Id: I51aa300358013cb0e76704feb2115d2a7e260f8a
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/31193
Reviewed-by: Angel Pons 
Reviewed-by: David Guckian
Reviewed-by: Vanny E 
Tested-by: build bot (Jenkins) 
---
M src/include/cpu/x86/msr.h
M src/soc/intel/denverton_ns/include/soc/msr.h
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Vanny E: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  David Guckian: Looks good to me, but someone else must approve

diff --git a/src/include/cpu/x86/msr.h b/src/include/cpu/x86/msr.h
index 5c6cae3..8c558ce 100644
--- a/src/include/cpu/x86/msr.h
+++ b/src/include/cpu/x86/msr.h
@@ -37,6 +37,8 @@
 #define IA32_PERF_CTL			0x199
 #define IA32_THERM_INTERRUPT		0x19b
 #define IA32_MISC_ENABLE		0x1a0
+#define  FAST_STRINGS_ENABLE_BIT	(1 << 0)
+#define  SPEED_STEP_ENABLE_BIT		(1 << 16)
 #define IA32_ENERGY_PERF_BIAS		0x1b0
 #define  ENERGY_POLICY_PERFORMANCE	0
 #define  ENERGY_POLICY_NORMAL		6
diff --git a/src/soc/intel/denverton_ns/include/soc/msr.h b/src/soc/intel/denverton_ns/include/soc/msr.h
index 1b27eef..0d469c4 100644
--- a/src/soc/intel/denverton_ns/include/soc/msr.h
+++ b/src/soc/intel/denverton_ns/include/soc/msr.h
@@ -96,10 +96,6 @@
 #define SMRR_SUPPORTED (1 << 11)
 #define PRMRR_SUPPORTED (1 << 12)

-/* IA32_MISC_ENABLE bits */
-#define FAST_STRINGS_ENABLE_BIT (1 << 0)
-#define SPEED_STEP_ENABLE_BIT (1 << 16)
-
 /* Read BCLK from MSR */
 unsigned int bus_freq_khz(void);