Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 18: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/29470/18/src/mainboard/portwell/m10...
File src/mainboard/portwell/m107/Kconfig:
https://review.coreboot.org/c/coreboot/+/29470/18/src/mainboard/portwell/m10...
PS18, Line 58: config CPU_MICROCODE_CBFS_LEN
: hex
: default 0x10C00
: help
: This should be updated when the microcode patch changes.
If you're not using special microcode, it seems like this should be in the SOC, not in the Mainboard. Since I don't see it for other braswell boards I wonder why it's needed here.
Feel free to change this in a follow-on if any changes are needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 18
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 14:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment