Attention is currently required from: Johannes Hahn, Werner Zeh.
Mario Scheithauer has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/85606?usp=email )
Change subject: soc/intel/common/block/power_limit: Disable RAPL via MSR completely
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/soc/intel/common/block/power_limit/power_limit.c:
https://review.coreboot.org/c/coreboot/+/85606/comment/171186de_a5008fa3?usp... :
PS3, Line 95: *
I think you don't need the star at this point.
look https://doc.coreboot.org/contributing/coding_style.html
'Commenting'
...and you should put a period at the end of the sentence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8272339a991667d5ba177f4755ec40e1961d729e
Gerrit-Change-Number: 85606
Gerrit-PatchSet: 3
Gerrit-Owner: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-Attention: Johannes Hahn
johannes-hahn@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sat, 21 Dec 2024 21:09:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes