Change in ...coreboot[master]: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32096
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
Add HrP 9560 module device ID (0x06F0) into device/pci_ids.h file.
TEST=HrP module is getting detected during PCI enumeration
Change-Id: I8f6d89b1c6d03e2497f6b345a520323f45247d7e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/wifi/wifi.c M src/include/device/pci_ids.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/32096/1
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index c0f665f..83cfaa9 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -327,6 +327,7 @@ PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI, PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI, PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI, + PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI, 0 };
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index dc55bf9..85bd6c3 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3219,6 +3219,7 @@ #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI 0x34f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI 0xa0f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI 0x02f0 +#define PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI 0x06f0
#define PCI_VENDOR_ID_COMPUTONE 0x8e0e #define PCI_DEVICE_ID_COMPUTONE_IP2EX 0x0291
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32096/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32096/1//COMMIT_MSG@11 PS1, Line 11: HrP module is getting detected during PCI enumeration On which platform?
Hello Aaron Durbin, Patrick Rudolph, Aamir Bohra, Duncan Laurie, Rizwan Qureshi, Lijian Zhao, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32096
to look at the new patch set (#2).
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
Add HrP 9560 module device ID (0x06F0) into device/pci_ids.h file.
TEST=HrP module is getting detected during PCI enumeration on CMLRVP
Change-Id: I8f6d89b1c6d03e2497f6b345a520323f45247d7e Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/drivers/intel/wifi/wifi.c M src/include/device/pci_ids.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/32096/2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32096/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32096/1//COMMIT_MSG@11 PS1, Line 11: HrP module is getting detected during PCI enumeration
On which platform?
CMLRVP
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 2: Code-Review+1
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32096 )
Change subject: drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module ......................................................................
drivers/intel/wifi: Add support for Harrison Peak (HrP) 9560 module
Add HrP 9560 module device ID (0x06F0) into device/pci_ids.h file.
TEST=HrP module is getting detected during PCI enumeration on CMLRVP
Change-Id: I8f6d89b1c6d03e2497f6b345a520323f45247d7e Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32096 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/wifi/wifi.c M src/include/device/pci_ids.h 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Furquan Shaikh: Looks good to me, approved Lijian Zhao: Looks good to me, approved
diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index c0f665f..83cfaa9 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -327,6 +327,7 @@ PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI, PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI, PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI, + PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI, 0 };
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index dc55bf9..85bd6c3 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3219,6 +3219,7 @@ #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI 0x34f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI 0xa0f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_3_WIFI 0x02f0 +#define PCI_DEVICE_ID_HrP_9560_SERIES_4_WIFI 0x06f0
#define PCI_VENDOR_ID_COMPUTONE 0x8e0e #define PCI_DEVICE_ID_COMPUTONE_IP2EX 0x0291
-
Furquan Shaikh (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)