Attention is currently required from: Jérémy Compostella, Kapil Porwal, Nick Vaccaro.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71295 )
Change subject: soc/intel/alderlake: Add entries to eventLog on invocation of early SOL
......................................................................
Patch Set 17:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71295/comment/6618f6b8_9a3762a3
PS15, Line 10: retraining
training (it could technically be the first one).
Done
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/71295/comment/c63deb7d_ac2ea170
PS15, Line 23: nclude <elog.h>
Usually, includes should follow the alphabetical order.
Done
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/71295/comment/b27e6aa5_0c87c0d0
PS15, Line 27: include <elog.h>
Same here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8181370633a1ecff77b051d3110f593c3eb484a2
Gerrit-Change-Number: 71295
Gerrit-PatchSet: 17
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 16:56:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment