Change in coreboot[master]: cpu/intel/common: Enable GetSec leafes for Intel TXT

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leafes for Intel TXT
......................................................................

cpu/intel/common: Enable GetSec leafes for Intel TXT

Similar to VMX and SMX also enable all GetSec leafes for Intel TXT.

Change-Id: I89620c2a98cfceaa785b1a798fafbf35cc99a0b2
Signed-off-by: Patrick Rudolph 
---
M src/cpu/intel/common/common_init.c
1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36092/1

diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c
index 2fff90c..93d324e 100644
--- a/src/cpu/intel/common/common_init.c
+++ b/src/cpu/intel/common/common_init.c
@@ -56,8 +56,13 @@

if (enable) {
    	msr.lo |= (1 << 2);
-		if (feature_flag & CPUID_SMX)
+		if (feature_flag & CPUID_SMX) {
    		msr.lo |= (1 << 1);
+			if (CONFIG(INTEL_TXT)) {
+				/* Enable GetSec and all GetSec leafes */
+				msr.lo |= (0xff << 8);
+			}
+		}
    }

wrmsr(IA32_FEATURE_CONTROL, msr);

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leafes for Intel TXT
......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@7 
PS1, Line 7: leafes
leaves?

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@9 
PS1, Line 9: leafes
Ditto.

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@10 
PS1, Line 10: 
How can it be tested, that the leaves are enabled?

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leafes for Intel TXT
......................................................................

Patch Set 1: Code-Review+2

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leafes for Intel TXT
......................................................................

Patch Set 1: Code-Review+2

Change in coreboot[master]: cpu/intel/common: Enable GetSec leaves for Intel TXT

[Patrick Rudolph (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36092

to look at the new patch set (#2).

Change subject: cpu/intel/common: Enable GetSec leaves for Intel TXT
......................................................................

cpu/intel/common: Enable GetSec leaves for Intel TXT

Similar to VMX and SMX also enable all GetSec leaves for Intel TXT.

Change-Id: I89620c2a98cfceaa785b1a798fafbf35cc99a0b2
Signed-off-by: Patrick Rudolph 
---
M src/cpu/intel/common/common_init.c
1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36092/2

Change in coreboot[master]: cpu/intel/common: Enable GetSec leaves for Intel TXT

[Patrick Rudolph (Code Review)]

Hello Patrick Rudolph, David Hendricks, Philipp Deppenwiese, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36092

to look at the new patch set (#3).

Change subject: cpu/intel/common: Enable GetSec leaves for Intel TXT
......................................................................

cpu/intel/common: Enable GetSec leaves for Intel TXT

Similar to VMX and SMX also enable all GetSec leaves for Intel TXT.

Change-Id: I89620c2a98cfceaa785b1a798fafbf35cc99a0b2
Signed-off-by: Patrick Rudolph 
---
M src/cpu/intel/common/common_init.c
1 file changed, 6 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/36092/3

Change in coreboot[master]: cpu/intel/common: Enable GetSec leaves for Intel TXT

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leaves for Intel TXT
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@7 
PS1, Line 7: leafes
> leaves?

Done

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@9 
PS1, Line 9: leafes
> Ditto.

Done

https://review.coreboot.org/c/coreboot/+/36092/1//COMMIT_MSG@10 
PS1, Line 10:
> How can it be tested, that the leaves are enabled?

Issue the corresponding GetSec instruction.

Change in coreboot[master]: cpu/intel/common: Enable GetSec leaves for Intel TXT

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leaves for Intel TXT
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: cpu/intel/common: Enable GetSec leaves for Intel TXT

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36092 )

Change subject: cpu/intel/common: Enable GetSec leaves for Intel TXT
......................................................................

cpu/intel/common: Enable GetSec leaves for Intel TXT

Similar to VMX and SMX also enable all GetSec leaves for Intel TXT.

Change-Id: I89620c2a98cfceaa785b1a798fafbf35cc99a0b2
Signed-off-by: Patrick Rudolph 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36092
Tested-by: build bot (Jenkins) 
Reviewed-by: Philipp Deppenwiese 
---
M src/cpu/intel/common/common_init.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Philipp Deppenwiese: Looks good to me, approved

diff --git a/src/cpu/intel/common/common_init.c b/src/cpu/intel/common/common_init.c
index 2fff90c..9819ee7 100644
--- a/src/cpu/intel/common/common_init.c
+++ b/src/cpu/intel/common/common_init.c
@@ -56,8 +56,13 @@

if (enable) {
    	msr.lo |= (1 << 2);
-		if (feature_flag & CPUID_SMX)
+		if (feature_flag & CPUID_SMX) {
    		msr.lo |= (1 << 1);
+			if (CONFIG(INTEL_TXT)) {
+				/* Enable GetSec and all GetSec leaves */
+				msr.lo |= (0xff << 8);
+			}
+		}
    }

wrmsr(IA32_FEATURE_CONTROL, msr);