Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39718 )
Change subject: intel/common/fast_spi: Add Protected Range support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39718/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39718/4//COMMIT_MSG@8
PS4, Line 8:
Please give a little background.
https://review.coreboot.org/c/coreboot/+/39718/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/39718/4/src/soc/intel/common/block/...
PS4, Line 202: return dlock ? 0 : -1;
Use CB_SUCCESS and friends?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39718
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia70afb8286bce882cd98a028cfd6c79bc9d624a1
Gerrit-Change-Number: 39718
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 14:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment