Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83984?usp=email )
Change subject: mb/google/brox: Enable storage devices on unprovisioned fw_config ......................................................................
mb/google/brox: Enable storage devices on unprovisioned fw_config
Storage devices are very critical to boot to OS. When probe list is defined for storage devices, all of them get disabled when fw_config is unprovisioned - a typical situation in the factory. Fix this by configuring the storage devices in device/override tree to probe and enable them when fw_config is unprovisioned.
BUG=None TEST=Build Brox firmware and boot to OS when fw_config is unprovisioned.
Change-Id: I0537f7d1d83293b9b3408f0aadf11fa2e7908163 Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83984 Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Jon Murphy jpmurphy@google.com Reviewed-by: Bob Moragues moragues@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brox/variants/brox/overridetree.cb M src/mainboard/google/brox/variants/jubilant/overridetree.cb M src/mainboard/google/brox/variants/lotso/overridetree.cb 3 files changed, 9 insertions(+), 0 deletions(-)
Approvals: Bob Moragues: Looks good to me, but someone else must approve build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Jon Murphy: Looks good to me, approved
diff --git a/src/mainboard/google/brox/variants/brox/overridetree.cb b/src/mainboard/google/brox/variants/brox/overridetree.cb index 21774f8..18baa5d 100644 --- a/src/mainboard/google/brox/variants/brox/overridetree.cb +++ b/src/mainboard/google/brox/variants/brox/overridetree.cb @@ -290,6 +290,7 @@ .flags = PCIE_RP_LTR | PCIE_RP_AER, }" probe STORAGE STORAGE_NVME + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -327,9 +328,11 @@ end probe ISH ISH_ENABLE probe STORAGE STORAGE_UFS + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UFS + probe unprovisioned end end end diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb index 0613ff9..01ac731 100644 --- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb +++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb @@ -295,6 +295,7 @@ }" probe STORAGE STORAGE_NVME probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -333,10 +334,12 @@ end probe STORAGE STORAGE_UFS probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UFS probe STORAGE STORAGE_UNKNOWN + probe unprovisioned end device ref i2c0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb index e7c5f6b..6876b64 100644 --- a/src/mainboard/google/brox/variants/lotso/overridetree.cb +++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb @@ -333,6 +333,7 @@ }" probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_NVME + probe unprovisioned end device ref pcie_rp5 on register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -382,10 +383,12 @@ end probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS + probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UNKNOWN probe STORAGE STORAGE_UFS + probe unprovisioned end device ref i2c0 on chip drivers/i2c/generic