Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63953 )
Change subject: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63953/comment/f99f3669_64f29be4 PS3, Line 7: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done
Please make it a statement by adding a verb in imperative mood: […]
Ack
https://review.coreboot.org/c/coreboot/+/63953/comment/23aa3711_e455d7d6 PS3, Line 10:
See CB:63954 (the other patch in the train)
marking done as Angel already shared the consumer CL.
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/63953/comment/4d921e57_4af66a82 PS3, Line 799: printk(BIOS_ERR, "PMC: Failed sending PCI Enumeration Done Command\n");
What are the consequences, and what should be done in this case?
it's very tough to say as we don't know what PMC does when it doesn't receive this PMC IPC command, for example: so far on ADL FSP, this command was missing and seems like everything is working till date. I believe this is more about informing PMC that we are done with pre-boot phases.
Please let me know if you have some further concerns