Attention is currently required from: Angel Pons, Máté Kukri, Nico Huber.
Hello Angel Pons, Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83736?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by Angel Pons
Change subject: mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation ......................................................................
mb/dell/optiplex_9020: Fix 0-division and unintended truncation in package power calculation
- If `rapl_power_unit == 0`, `pkg_power_info / rapl_power_unit` is invalid - If `rapl_power_unit > 7`, the result of the shift doesn't fit into a `uint8_t`
Signed-off-by: Mate Kukri km@mkukri.xyz Change-Id: I48ef59c4fbeb0a55675ac24da31e6e0b194cb58d --- M src/mainboard/dell/optiplex_9020/mainboard.c 1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/83736/2