Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 )
Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62330/comment/5af09b11_6dc391a9
PS10, Line 213: rp6_wwan
Oh wait, don't we want
`pcie_rp6`
here?
so that the property is under _SB.PCI0.RP6 ?
It is supposed to be the root port and the device itself, so I would expect RP6 and then _SB.PCI0.RP6.PXSX
I already added support to the WWAN driver itself, see https://review.coreboot.org/c/coreboot/+/62436/4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62330
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f
Gerrit-Change-Number: 62330
Gerrit-PatchSet: 10
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Comment-Date: Thu, 10 Mar 2022 23:18:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment