[XL] Change in coreboot[main]: soc/meidatek/mt8196: Add SPM loader

[Ccong Chen (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.

Ccong Chen has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )

Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................

Patch Set 4:

(12 comments)

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/82c03cd9_4262ecec?usp... :
PS3, Line 636: 	u32 reserved1;
> Revert these unrelated changes.

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/854ad983_2625796f?usp... :
PS3, Line 690: 	u32 reserved12[3];
> Revert these unrelated changes.

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/08155de4_3ec31b32?usp... :
PS3, Line 717: reserved16
> Why is this changed to "reserved"?

spm_dpsw_con register address have been changed

https://review.coreboot.org/c/coreboot/+/85599/comment/8749d8e4_756ecfa3?usp... :
PS3, Line 1117: u32 pcm_apwdt_latch_27;
              : 	u32 pcm_apwdt_latch_28;
              : 	u32 pcm_apwdt_latch_29;
              : 	u32 pcm_apwdt_latch_30;
              : 	u32 pcm_apwdt_latch_31;
              : 	u32 pcm_apwdt_latch_32;
              : 	u32 pcm_apwdt_latch_33;
              : 	u32 pcm_apwdt_latch_34;
              : 	u32 pcm_apwdt_latch_35;
              : 	u32 pcm_apwdt_latch_36;
              : 	u32 pcm_apwdt_latch_37;
              : 	u32 pcm_apwdt_latch_38;
> `u32 pcm_apwdt_latch_27[12]`

Done

File src/soc/mediatek/mt8196/include/soc/spm.h:

https://review.coreboot.org/c/coreboot/+/85599/comment/4373d35b_83fb2e47?usp... :
PS1, Line 13: 0x1c001108
> I meant defining a structure similar to `mtk_vlpcksys_regs`.

Done

File src/soc/mediatek/mt8196/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/6c1a7f54_19d98660?usp... :
PS1, Line 738: status
> Not done.

Done

File src/soc/mediatek/mt8196/spm.c:

https://review.coreboot.org/c/coreboot/+/85599/comment/fd5f240c_f9933631?usp... :
PS3, Line 742: 				SPM_ACK_CHK_3_CON_EN);
> align

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/4834649f_59873c6c?usp... :
PS3, Line 744:
> Remove blank line

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/9388b2db_47f6f00a?usp... :
PS3, Line 753: 				SPM_ACK_CHK_3_CON_HW_MODE_TRIG | SPM_ACK_CHK_3_CON_CLR_ALL,
> align

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/e32db514_40dfd03b?usp... :
PS3, Line 816: spm_resource_ack_con
> `spm_resource_ack_con[0]`

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/75f4cfab_95a0dcc1?usp... :
PS3, Line 827: spm_resource_ack_con
> `spm_resource_ack_con[0]`

Done

https://review.coreboot.org/c/coreboot/+/85599/comment/b9e6b649_fff69979?usp... :
PS3, Line 835: (
> remove

Done