Attention is currently required from: Felix Held. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52671 )
Change subject: superio/nuvoton/npcd378: Fall back to non-negative value ......................................................................
superio/nuvoton/npcd378: Fall back to non-negative value
This change is needed to update the option API to use unsigned integers. The CMOS option system does not support negative numbers. So, adjust the call to get_int_option() to use 3 as fallback instead of -1.
Change-Id: I46c5f5c6f47f99379cbafc0d60258b99dc512e9d Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/superio/nuvoton/npcd378/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/52671/1
diff --git a/src/superio/nuvoton/npcd378/superio.c b/src/superio/nuvoton/npcd378/superio.c index 6a56ac8..e073dc3 100644 --- a/src/superio/nuvoton/npcd378/superio.c +++ b/src/superio/nuvoton/npcd378/superio.c @@ -68,7 +68,7 @@
npcd378_hwm_write_start(res->base);
- int fan_lvl = get_int_option("psu_fan_lvl", -1); + int fan_lvl = get_int_option("psu_fan_lvl", 3); if (fan_lvl < 0 || fan_lvl > 7) fan_lvl = 3;