Change in ...coreboot[master]: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31912
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports
There are 3 PCI-E 1x ports on p5q_pro and p5qc, which correspond to the first three functions of 1c.
Confirmed on a p5q_pro board.
Change-Id: I779400494e27bf046996512d1f772311e6e4e091 Signed-off-by: Bill XIE persmule@gmail.com --- M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/31912/1
diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index d645609..a1310b9 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -52,8 +52,8 @@ device pci 1a.7 on end # USB device pci 1b.0 on end # Audio device pci 1c.0 on end # PCIe 1 - device pci 1c.1 off end # PCIe 2 - device pci 1c.2 off end # PCIe 3 + device pci 1c.1 on end # PCIe 2 + device pci 1c.2 on end # PCIe 3 device pci 1c.3 off end # PCIe 4 device pci 1c.4 on end # PCIe 5 MARVELL IDE device pci 1c.5 on end # PCIe 6 diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 8420124..b6146ec 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -52,8 +52,8 @@ device pci 1a.7 on end # USB device pci 1b.0 on end # Audio device pci 1c.0 on end # PCIe 1 - device pci 1c.1 off end # PCIe 2 - device pci 1c.2 off end # PCIe 3 + device pci 1c.1 on end # PCIe 2 + device pci 1c.2 on end # PCIe 3 device pci 1c.3 off end # PCIe 4 device pci 1c.4 on end # PCIe 5 MARVELL IDE device pci 1c.5 on end # PCIe 6
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31912 )
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
Patch Set 1:
Please help to confirm this on p5qc.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31912 )
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
Patch Set 1: Code-Review+1
Looks good. Maybe it is worth listing what is on each PCIe lane, such as ethernet, physical ports and such. I only have the P5QL PRO, so I am afraid I cannot test anything.
Hello Angel Pons, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31912
to look at the new patch set (#2).
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports
There are 3 PCI-E 1x ports on p5q_pro and p5qc, which correspond to the first three functions of 1c.
Confirmed on a p5q_pro board.
Change-Id: I779400494e27bf046996512d1f772311e6e4e091 Signed-off-by: Bill XIE persmule@gmail.com --- M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/31912/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31912 )
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31912 )
Change subject: mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports ......................................................................
mb/asus/{p5qc,p5q_pro}: Correct mapping of PCI-E 1x ports
There are 3 PCI-E 1x ports on p5q_pro and p5qc, which correspond to the first three functions of 1c.
Confirmed on a p5q_pro board.
Change-Id: I779400494e27bf046996512d1f772311e6e4e091 Signed-off-by: Bill XIE persmule@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31912 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb M src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb 2 files changed, 8 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb index d645609..6e0a40a 100644 --- a/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5q_pro/devicetree.cb @@ -51,12 +51,12 @@ device pci 1a.2 on end # USB device pci 1a.7 on end # USB device pci 1b.0 on end # Audio - device pci 1c.0 on end # PCIe 1 - device pci 1c.1 off end # PCIe 2 - device pci 1c.2 off end # PCIe 3 + device pci 1c.0 on end # PCIe 1 slot 1 + device pci 1c.1 on end # PCIe 2 slot 2 + device pci 1c.2 on end # PCIe 3 slot 3 device pci 1c.3 off end # PCIe 4 device pci 1c.4 on end # PCIe 5 MARVELL IDE - device pci 1c.5 on end # PCIe 6 + device pci 1c.5 on end # PCIe 6 ethernet NIC device pci 1d.0 on end # USB device pci 1d.1 on end # USB device pci 1d.2 on end # USB diff --git a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb index 8420124..902dcfd 100644 --- a/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb +++ b/src/mainboard/asus/p5qc/variants/p5qc/devicetree.cb @@ -51,12 +51,12 @@ device pci 1a.2 on end # USB device pci 1a.7 on end # USB device pci 1b.0 on end # Audio - device pci 1c.0 on end # PCIe 1 - device pci 1c.1 off end # PCIe 2 - device pci 1c.2 off end # PCIe 3 + device pci 1c.0 on end # PCIe 1 slot 1 + device pci 1c.1 on end # PCIe 2 slot 2 + device pci 1c.2 on end # PCIe 3 slot 3 device pci 1c.3 off end # PCIe 4 device pci 1c.4 on end # PCIe 5 MARVELL IDE - device pci 1c.5 on end # PCIe 6 + device pci 1c.5 on end # PCIe 6 ethernet NIC device pci 1d.0 on end # USB device pci 1d.1 on end # USB device pci 1d.2 on end # USB
-
Angel Pons (Code Review) -
Bill XIE (Code Review)
-
Patrick Georgi (Code Review)