Attention is currently required from: Julius Werner, Maximilian Brune, Patrick Rudolph, Reka Norman.
Raul Rangel has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/83208?usp=email )
Change subject: commonlib/device_tree: Improve node and property allocation speed
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/83208/comment/40197dcd_a0c2873c?usp... :
PS2, Line 37: 2000
nit: `#define` the constants
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83208?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f4d80a8b750febfb069b32ef47304ccecdc35af
Gerrit-Change-Number: 83208
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Tue, 25 Jun 2024 21:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes