Attention is currently required from: Arthur Heymans, Dinesh Gehlot, Julius Werner, Kapil Porwal, Lean Sheng Tan, Werner Zeh.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email )
Change subject: src: Implement framework for PRERAM VSD store
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
Thinking load here, do we really need cbmem_vsd_find() API?
we can always use cbmem_find(cbmem_id) to get the VSD data from cbmem region.
Even for cbmem_vsd_add() API, if we can add the minimal code inside existing cbmem_add() API to support VSD data structure, we cab eventually drop those two new APIs. Just the CBMEM_ID is enough to add/find the VSD region.
This might also help to address the comment from Julius.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76393?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0baebb902807d5403800ac18757512bd2a59d2b9
Gerrit-Change-Number: 76393
Gerrit-PatchSet: 12
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 05:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment