Attention is currently required from: Hung-Te Lin, cong yang, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74341 )
Change subject: soc/mediatek: Add support for regulator VIO18
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/74341/comment/46770e22_f0682a7d
PS4, Line 927: case MT6366_VIO18:
1800000 seems to be used in several places in this file, and there are some 2900000/3000000/3300000, […]
Just the 2 occurrences of 1800000 for vio18. And another patch for the 2 occurrences of 1200000 for vrf12.
Let's leave the other constants 2900000/3000000/3300000 for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3c3aa105e648b87fc39f881d762002f67b4422b5
Gerrit-Change-Number: 74341
Gerrit-PatchSet: 6
Gerrit-Owner: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 04:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cong yang
yangcong5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment