Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
MAINTAINERS: add maintainers of soc/amd/picassso
Change-Id: Id39bd55a9a05b062892defadeb652980213b1e9c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M MAINTAINERS 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/47577/1
diff --git a/MAINTAINERS b/MAINTAINERS index 9a31a3f..fa8b492 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -529,6 +529,14 @@ # Systems on a Chip ################################################################################
+AMD Picasso +M: Marshall Dawson marshalldawson3rd@gmail.com +M: Felix Held felix-coreboot@felixheld.de +M: Jason Glenesk jason.glenesk@gmail.com +S: Maintained +F: /src/soc/amd/picasso +F: /src/vendorcode/amd/fsp/picasso + INTEL APOLLOLAKE_SOC M: Andrey Petrov andrey.petrov@gmail.com S: Maintained
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS@536 PS1, Line 536: Maintained I imagine you're paid to maintain this platform? If so, I'd use `Supported`.
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS@537 PS1, Line 537: / no leading slash, please
Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47577
to look at the new patch set (#2).
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
MAINTAINERS: add maintainers of soc/amd/picassso
Change-Id: Id39bd55a9a05b062892defadeb652980213b1e9c Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M MAINTAINERS 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/47577/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS@536 PS1, Line 536: Maintained
I imagine you're paid to maintain this platform? If so, I'd use `Supported`.
thought about that, but I even though I try to, I can't guarantee that I'll be able to review all related patches within a week when I'm already actively working on the next generations. So setting it to maintained instead of supported lowers the expectation a bit and gives me a bit more slack there.
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS@537 PS1, Line 537: /
no leading slash, please
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/47577/1/MAINTAINERS@536 PS1, Line 536: Maintained
thought about that, but I even though I try to, I can't guarantee that I'll be able to review all re […]
Understandable, ack.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47577 )
Change subject: MAINTAINERS: add maintainers of soc/amd/picassso ......................................................................
MAINTAINERS: add maintainers of soc/amd/picassso
Change-Id: Id39bd55a9a05b062892defadeb652980213b1e9c Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47577 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M MAINTAINERS 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/MAINTAINERS b/MAINTAINERS index 9a31a3f..1f4df52 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -529,6 +529,14 @@ # Systems on a Chip ################################################################################
+AMD Picasso +M: Marshall Dawson marshalldawson3rd@gmail.com +M: Felix Held felix-coreboot@felixheld.de +M: Jason Glenesk jason.glenesk@gmail.com +S: Maintained +F: src/soc/amd/picasso +F: src/vendorcode/amd/fsp/picasso + INTEL APOLLOLAKE_SOC M: Andrey Petrov andrey.petrov@gmail.com S: Maintained
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Marshall Dawson (Code Review)