Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31548 )
Change subject: security: Add memory subfolder ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/#/c/31548/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31548/5//COMMIT_MSG@10 PS5, Line 10: Introduce Kconfig PLATFORM_HAS_DRAM_CLEAR that is to be selected by : platforms, that are able to clear all DRAM. : : Introduce Kconfig SECURITY_CLEAR_DRAM_ON_REGULAR_BOOT that is user : selectable to always clear DRAM on non S3 boot. : : The function security_clear_dram_request tells the calling platform when : to wipe all DRAM. Will be extended by TEE frameworks. : : Add Documentation for the new security API. Enumerate these items?
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... File Documentation/security/memory_clearing.md:
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 14: bringup bring-up?
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 15: SoC device?
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 22: 4. All DRAM is cleared with zeros Can you elaborate, why 0 is the way to go and not something random?
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 26: platforms singular
https://review.coreboot.org/#/c/31548/5/Documentation/security/memory_cleari... PS5, Line 27: call calls
https://review.coreboot.org/#/c/31548/5/src/security/memory/Kconfig File src/security/memory/Kconfig:
https://review.coreboot.org/#/c/31548/5/src/security/memory/Kconfig@30 PS5, Line 30: of additional security implementations in use. Please add a blank line below.
https://review.coreboot.org/#/c/31548/5/src/security/memory/memory.c File src/security/memory/memory.c:
https://review.coreboot.org/#/c/31548/5/src/security/memory/memory.c@28 PS5, Line 28: return 1; : : /* TODO: Add TEE environments here */ : : return 0; Use `true` and `false` as the type is `bool`? The macros are defined in `stdint.h`.
-
Paul Menzel (Code Review)