HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46202 )
Change subject: mb/lenovo/x1_carbon_gen1: Convert to ASL 2.0 syntax ......................................................................
mb/lenovo/x1_carbon_gen1: Convert to ASL 2.0 syntax
Change-Id: I9764d90e713f35d54056fbafae3e3ada18bea1eb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/46202/1
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46202 )
Change subject: mb/lenovo/x1_carbon_gen1: Convert to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46202 )
Change subject: mb/lenovo/x1_carbon_gen1: Convert to ASL 2.0 syntax ......................................................................
mb/lenovo/x1_carbon_gen1: Convert to ASL 2.0 syntax
Change-Id: I9764d90e713f35d54056fbafae3e3ada18bea1eb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46202 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl index 40b9a53..c4becaf 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/acpi/platform.asl @@ -16,8 +16,8 @@ Method(_WAK,1) { /* ME may not be up yet. */ - Store (0, _TZ.MEB1) - Store (0, _TZ.MEB2) + _TZ.MEB1 = 0 + _TZ.MEB2 = 0
/* Wake the HKEY to init BT/WWAN */ _SB.PCI0.LPCB.EC.HKEY.WAKE (Arg0)
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)