Attention is currently required from: Raul Rangel, Kangheui Won, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68953 )
Change subject: security/vboot: Update build rules using x86 SHA extension ......................................................................
Patch Set 2:
(2 comments)
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68953/comment/b7120b57_2dd94197 PS2, Line 26: ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y) Sorry, maybe I'm confused, but isn't this the wrong way around? When verstage is x86 (top branch) you want to respect the Kconfig, when it isn't (bottom branch) you want to just disable acceleration. Did you mean to write `ifneq` instead?
https://review.coreboot.org/c/coreboot/+/68953/comment/9052c5a8_0cd7c091 PS2, Line 43: X86_SHA_EXT="$$(X86_SHA_EXT_$(1))" \ I think a more generic way to write this could be ``` X86_SHA_EXT="$(if $(CONFIG_ARCH_$(call toupper,$(1))_X86_32)$(CONFIG_ARCH_$(call toupper,$(1))_X86_64),$(CONFIG_VBOOT_X86_SHA256_ACCELERATION))" ```