[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Subrata Banik (Code Review)]

Attention is currently required from: Kapil Porwal, Pranava Y N, Saurabh Mishra.

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 59:

(8 comments)

File src/soc/intel/pantherlake/acpi.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/649bc21e_79575094?usp... :
PS59, Line 117: 	static acpi_cstate_t map[MAX(ARRAY_SIZE(cstate_set_s0ix),
              : 				ARRAY_SIZE(cstate_set_non_s0ix))] = { {0} };
this is local variable and then declared as static. why you need to initialize it with zero ?

array elements would be default assigned to zero w/o any explicit assignment

https://review.coreboot.org/c/coreboot/+/83798/comment/0223af74_04eac8eb?usp... :
PS59, Line 125: map
why ? you should return NULL here and update the common code to handle the NULL code

```
static void generate_c_state_entries(void)
{
    const acpi_cstate_t *c_state_map;
    size_t entries;

c_state_map = soc_get_cstate_map(&entries);
    if (c_state_map == NULL)
        return;

/* Generate C-state tables */
    acpigen_write_CST_package(c_state_map, entries);
}
```

https://review.coreboot.org/c/coreboot/+/83798/comment/fcd857a3_b9077ece?usp... :
PS59, Line 243: 		printk(BIOS_DEBUG, "DMAR engine1 ACPI added\n");
please drop this. seems redundant

https://review.coreboot.org/c/coreboot/+/83798/comment/0eaeac75_629a443d?usp... :
PS59, Line 257: 		printk(BIOS_DEBUG, "DMAR engine2 ACPI added\n");
same

https://review.coreboot.org/c/coreboot/+/83798/comment/ce0fd7be_db64efac?usp... :
PS59, Line 272: 0x4
did you ignore my comments to use macro rather using hardcoded values ?

https://review.coreboot.org/c/coreboot/+/83798/comment/04be5a2e_acadf0e3?usp... :
PS59, Line 274: 		printk(BIOS_DEBUG, "DMAR engine3 ACPI added\n");
same

https://review.coreboot.org/c/coreboot/+/83798/comment/9f992ed7_1fdb2866?usp... :
PS59, Line 291: 		printk(BIOS_DEBUG, "DMAR RMRR ACPI added\n");
same

https://review.coreboot.org/c/coreboot/+/83798/comment/37757897_a420393e?usp... :
PS59, Line 305: 		printk(BIOS_DEBUG, "SATC ACPI added\n");
same