Attention is currently required from: Rory Liu, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 4: Code-Review+2
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61267/comment/11867212_2a9c72c3
PS1, Line 13:
We're not sure if it's necessary for other devices, so we make it optional. […]
I think may also depend on board design.
File src/drivers/net/chip.h:
https://review.coreboot.org/c/coreboot/+/61267/comment/06568f9f_b08a44f1
PS2, Line 35: /* Allow kernel driver to enable ASPM L1.2. */
: bool enable_aspm;
So coreboot already has a Kconfig option to enable ASPM on PCIe links (PCIEXP_ASPM, see https://revi […]
Done
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/587cf6b6_237f2ca1
PS3, Line 40: ASPM_L1_2 0xe059000f
nit: […]
Ack
https://review.coreboot.org/c/coreboot/+/61267/comment/af4d600d_30e149eb
PS3, Line 359: /* Enable ASPM_L1.2 */
: if (CONFIG(PCIEXP_ASPM))
: enable_aspm_l1_2(io_base);
I see, thank you for the explanation. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 4
Gerrit-Owner: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 03:18:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Rory Liu
rory.liu@quanta.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment