Attention is currently required from: ChiaLing, Paul Menzel, Ryan Lin, Subrata Banik, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email )
Change subject: soc/intel/jasperlake: Add per-SKU power limits
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/blipper/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75679/comment/8f27bbc7_2d5baee1 :
PS5, Line 62: register "power_limits_config" = "{
: .tdp_pl1_override = 6,
: .tdp_pl2_override = 20,
: }"
Sorry, this is actually not equivalent because the baseboard sets pl4 too. In CB:75395 you were setting pl4 for these variants so I got confused. Can you please add these back for all CPU SKUs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75679?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd
Gerrit-Change-Number: 75679
Gerrit-PatchSet: 5
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: ChiaLing
chia-ling.hou@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 01:23:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment