Akash Asthana has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29104 )
Change subject: sdm845: Port I2C driver
......................................................................
Patch Set 35:
(2 comments)
https://review.coreboot.org/#/c/29104/35/src/mainboard/google/cheza/mainboar...
File src/mainboard/google/cheza/mainboard.c:
https://review.coreboot.org/#/c/29104/35/src/mainboard/google/cheza/mainboar...
PS35, Line 46: i2c_init(QUPV3_1_SE4, I2C_SPEED_FAST);
nit: Please add a comment on the side explaining what this is (e.g. […]
Done
https://review.coreboot.org/#/c/29104/35/src/soc/qualcomm/sdm845/i2c.c
File src/soc/qualcomm/sdm845/i2c.c:
https://review.coreboot.org/#/c/29104/35/src/soc/qualcomm/sdm845/i2c.c@158
PS35, Line 158: /* If stretch bit is set to 1 master will send repeated start
Incorrect comment style, please use […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb76564d8a11427423dd14d8ba7c8c7d500ef346
Gerrit-Change-Number: 29104
Gerrit-PatchSet: 35
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Jun 2019 11:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment