Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Andrey Petrov, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Tim Wawrzynczak, Morgan Jang, Felix Held. Hello build bot (Jenkins), Jonathan Zhang, Angel Pons, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Tim Wawrzynczak, Morgan Jang, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55114
to look at the new patch set (#2).
Change subject: [RFC]soc/intel/common/block/pmc: Don't link get_uint_option in SMM ......................................................................
[RFC]soc/intel/common/block/pmc: Don't link get_uint_option in SMM
The option backend used in SMM has several disadvantages: - Restoring the initial state when entering SMM is difficult - Accessing hardware is slow and steals time from ring 0 - When using PCI hardware additional checks on decoded memory regions would be necessary - It links in a lot of code, which defeats the aim to have a minimal SMM handler
Pass the power_on_after_fail option to SMM by using GNVS instead of including the option backend into SMM. With this change the option can no longer be updated at runtime.
Change-Id: I60986979d7f7905b312b7d03abd46ac0465ae4cf Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/intel/apollolake/acpi/globalnvs.asl M src/soc/intel/apollolake/include/soc/nvs.h M src/soc/intel/common/block/acpi/acpi/globalnvs.asl M src/soc/intel/common/block/include/intelblocks/nvs.h M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/skylake/acpi/globalnvs.asl M src/soc/intel/skylake/include/soc/nvs.h 10 files changed, 41 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/55114/2